Align plugin API getSession method signatures with VS Code API #10837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing readonly modifiers. Fixes eclipse-theia#10836 Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
JonasHelming
approved these changes
Mar 3, 2022
|
I will merge this without further review, as the change is so minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add missing readonly modifiers. This aligns the method signatures with https://github.com/microsoft/vscode/blob/1.64.2/src/vscode-dts/vscode.d.ts#L14290-L14320
Fixes #10836
Contributed on behalf of STMicroelectronics
Signed-off-by: Lucas Koehler [email protected]
Review checklist
Reminder for reviewers